Centralize "Split" File Path Generation#229
Open
tmooney wants to merge 24 commits into
Open
Conversation
susannasiebert
approved these changes
Nov 15, 2016
Collaborator
susannasiebert
left a comment
susannasiebert
left a comment
There was a problem hiding this comment.
+1. I could go either way with replacing the fasta_chunk variable.
Glad to see a PR from someone that isn't me. There is certainly a lot of room for improvement in this code.
tmooney
force-pushed
the
centralize_split_file_path_generation
branch
from
fc2dd34 to
b4a7934
Compare
Member
Author
|
I've rebased this to resolve the conflicts with #200. |
susannasiebert
force-pushed
the
develop
branch
2 times, most recently
from
8e5b202 to
935788e
Compare
tmooney
force-pushed
the
centralize_split_file_path_generation
branch
from
b4a7934 to
47a031d
Compare
susannasiebert
force-pushed
the
develop
branch
from
cbf0a94 to
201c249
Compare
susannasiebert
force-pushed
the
develop
branch
from
201c249 to
f91697f
Compare
tmooney
force-pushed
the
centralize_split_file_path_generation
branch
from
47a031d to
26ea758
Compare
Member
Author
|
I've rebased this again to address accumulated conflicts and added 3ceb7c7. |
susannasiebert
force-pushed
the
develop
branch
from
115ded4 to
16f73aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fasta_chunkvariable used in each of the status messages. It might simplify the code a little by removing a variable.