Conversation
…exture.updateLightTexture()
|
wonderful change @Celivalg |
HaXrDEV
added a commit
to HaXrDEV/True-Darkness-Refabricated
that referenced
this pull request
Jan 26, 2024
Implemented "Moved LightMap update" pull request from upstream: grondag#43
|
Great work! Hope you don't mind me implementing this change into my updated fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved LightMap update to invoke of
DynamicTexture.upload()insideLightTexture.updateLightTexture()This allow other mods to get the LightMap after TrueDarkness updates it (aka DH, see #30 )
Tested on 1.19.2 on both Forge and Fabric
As a consequence, the
MixinDynamicTextureis not needed at all anymore, this streamlines the code a bit more.I couldn't make the 1.19 branch build and I don't know what's up with it, but 1.19.2 worked fine so here I am