S4R-9341 | update gb tracker to support conversational origin#249
S4R-9341 | update gb tracker to support conversational origin#249hdervisevic wants to merge 3 commits into
Conversation
hdervisevic
force-pushed
the
S4R-9341-updategb-tracker-clientandnative-app-sdk
branch
2 times, most recently
from
97ee49a to
9041c83
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds conversational commerce tracking support to the GB Tracker by introducing the origin.conversation flag for AutoSearch events. This enables accurate attribution of analytics data for conversational commerce interactions.
Key changes:
- Added
conversationflag to the origin interface and schema - Implemented test coverage for the new conversation origin flag
- Updated documentation with usage examples and guidelines
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/models.ts | Added conversation flag to SendableOrigin interface |
| src/schemas/autoSearch.ts | Added conversation field to schema with boolean type and default false |
| src/index.ts | Added conversation flag to GbTracker namespace Origin interface |
| test/events/autoSearch.spec.ts | Added test case for conversation origin flag propagation |
| test-integration/index.spec.js | Updated integration tests with CI improvements and conversation flag |
| README.md | Added documentation section explaining conversational commerce usage |
| .github/workflows/node.js.yml | Updated GitHub Actions to use newer versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '16' |
There was a problem hiding this comment.
The GitHub Actions have been updated to v4, but Node.js version remains at '16' which is approaching end-of-life. Consider updating to Node.js 18 or 20 for better security and performance.
| node-version: '16' | |
| node-version: '20' |
There was a problem hiding this comment.
we cant easily upgrade node version because of a issue with new openSSL 3 error that will occour on node version > 17 we will fix this in second ticket
Implements the `origin.conversation` flag for AutoSearch events to correctly attribute analytics for Conversational Commerce. Also includes: - Updates GitHub Actions to use newer versions. - Adds CI arguments for puppeteer to run in CI environments. - Adds timezone offset to visit events.
hdervisevic
force-pushed
the
S4R-9341-updategb-tracker-clientandnative-app-sdk
branch
from
a1abf9f to
651402f
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updates gb-tracker-client version to 5.5.0 Related to S4R-9341
Updates the gb-tracker-client dependency to the latest version, 5.5.0. This aligns the client with the newest features and improvements.
hdervisevic
force-pushed
the
S4R-9341-updategb-tracker-clientandnative-app-sdk
branch
from
d7306ce to
bfd857d
Compare
Adds support for tracking Conversational Commerce events by introducing the
origin.conversationflag to the AutoSearch event.This allows for accurate attribution of analytics data for Conversational Commerce interactions. Includes documentation updates and tests.
Relates to S4R-9341