Skip to content

protoc-gen-rust-grpc: fix cmake by getting absl before protobuf #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfawley merged 2 commits into from
May 27, 2026
+7 −3
Merged

protoc-gen-rust-grpc: fix cmake by getting absl before protobuf #2658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7052b8f
protoc-gen-rust-grpc: fix cmake by getting absl before protobuf
dfawley May 27, 2026
2fa6738
another improvement to cmake
dfawley May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions protoc-gen-rust-grpc/src/cpp_source/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

if(MINGW)
add_compile_options("-Wa,-mbig-obj")
add_compile_definitions(_WIN32_WINNT=0x0601)
elseif(MSVC)
add_compile_options("/bigobj")
endif()
Expand All @@ -36,9 +37,6 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
include(FetchContent)
include(FetchProtobuf)

# Download and configure protobuf
fetch_protobuf(${PROTOBUF_VERSION})

# Download and configure abseil
# Abseil version that's compatible with protobuf
set(ABSEIL_VERSION "20240722.0")
Expand Down Expand Up @@ -66,6 +64,12 @@ set(CMAKE_PREFIX_PATH "" CACHE STRING "" FORCE)

FetchContent_MakeAvailable(absl)

# Prevent protobuf from using a local version of abseil
set(protobuf_ABSL_PROVIDER "package" CACHE STRING "Use external Abseil" FORCE)

# Download and configure protobuf
fetch_protobuf(${PROTOBUF_VERSION})

# Add the protoc-gen-rust-grpc executable and installation rules
if(BUILD_PLUGIN)
add_executable(protoc-gen-rust-grpc
Expand Down
Loading