Skip to content

fix: port property leaks stale scheme default when scheme changes #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaoflow wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: port property leaks stale scheme default when scheme changes #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions furl/furl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,8 +1407,6 @@ def load(self, url):

self.netloc = tokens.netloc # Raises ValueError in Python 2.7+.
self.scheme = tokens.scheme
if not self.port:
self._port = DEFAULT_PORTS.get(self.scheme)
self.path.load(tokens.path)
self.query.load(tokens.query)
self.fragment.load(tokens.fragment)
Expand Down Expand Up @@ -1469,7 +1467,7 @@ def port(self, port):
Raises: ValueError on invalid port.
"""
if port is None:
self._port = DEFAULT_PORTS.get(self.scheme)
self._port = None
elif is_valid_port(port):
self._port = int(str(port))
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_furl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,7 +1511,7 @@ def test_basic_manipulation(self):
assert str(f) == 'http://www.yahoo.com/?foo=eep'

f.scheme = 'sup'
assert str(f) == 'sup://www.yahoo.com:80/?foo=eep'
assert str(f) == 'sup://www.yahoo.com/?foo=eep'

f.port = None
assert str(f) == 'sup://www.yahoo.com/?foo=eep'
Expand Down