Skip to content

@property (copy, nonatomic) NSString *title; 中已经有copy #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liugangios wants to merge 2 commits into
base: master
Choose a base branch
from
Open

@property (copy, nonatomic) NSString *title; 中已经有copy #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d4b110
@property (copy, nonatomic) NSString *title; 中已经有copy
liugangios Nov 6, 2017
9b5f2a4
NS_ENUM比enum更接近苹果风格，更优雅，且可以选择定义可选值数据类型为NSInteger，NS_ENUM为单选枚举宏，NS_OPT…
liugangios Nov 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SDCycleScrollView/Lib/SDCycleScrollView/SDCollectionViewCell.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ - (void)setupTitleLabel

- (void)setTitle:(NSString *)title
{
_title = [title copy];
_title = title;
Copy link
Copy Markdown

@developforapple developforapple Nov 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我认为，属性中的copy是在自动生成setter时采用copy方式赋值。
手动添加setter时仍然需要手动copy。
所以这里仍然需要 _title = [title copy];

_titleLabel.text = [NSString stringWithFormat:@" %@", title];
if (_titleLabel.hidden) {
_titleLabel.hidden = NO;
Expand Down
12 changes: 6 additions & 6 deletions SDCycleScrollView/Lib/SDCycleScrollView/SDCycleScrollView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,16 @@

#import <UIKit/UIKit.h>

typedef enum {
SDCycleScrollViewPageContolAlimentRight,
typedef NS_ENUM(NSInteger, SDCycleScrollViewPageContolAliment) {
SDCycleScrollViewPageContolAlimentRight = 0,
SDCycleScrollViewPageContolAlimentCenter
} SDCycleScrollViewPageContolAliment;
};

typedef enum {
SDCycleScrollViewPageContolStyleClassic, // 系统自带经典样式
typedef NS_ENUM(NSInteger, SDCycleScrollViewPageContolStyle) {
SDCycleScrollViewPageContolStyleClassic = 0, // 系统自带经典样式
SDCycleScrollViewPageContolStyleAnimated, // 动画效果pagecontrol
SDCycleScrollViewPageContolStyleNone // 不显示pagecontrol
} SDCycleScrollViewPageContolStyle;
};

@class SDCycleScrollView;

Expand Down