Skip to content

Bad version value prevents local phantom install#5

Open
jessejacob wants to merge 1 commit intogskachkov:masterfrom
jessejacob:master
Open

Bad version value prevents local phantom install#5
jessejacob wants to merge 1 commit intogskachkov:masterfrom
jessejacob:master

Conversation

@jessejacob
Copy link

This property is referred to by install.js as helper.version for comparison against the 'phantomjs.exe --version' result retrieved from
the copy(s) found in the system path. The version currently being downloaded by the app is '2.0.0 (development)', so currently if you
install the release version and just copy the downloaded phantomjs.exe into a folder in your path, when it finds it the install.js incorrectly
reports that it's the wrong version because it's expecting the output to be '2.0.0-20141016'. I personally think there needs to be a more
complicated evaluation rather than an exact match, so that any 2.x version would work, but this will suffice for now.

This property is referred to by install.js as helper.version for
comparison against the 'phantomjs.exe --version' result retrieved from
the copy(s) found in the system path. The version currently being
downloaded by the app is '2.0.0 (development)', so currently if you
install the release version and just copy the downloaded phantomjs.exe
into a folder in your path, when it finds it the install.js incorrectly
reports that it's the wrong version because it's expecting the output to
be '2.0.0-20141016'. I personally think there needs to be a more
complicated evaluation rather than an exact match, so that any 2.x
version would work, but this will suffice for now.
@mriddle
Copy link

mriddle commented Oct 1, 2015

+1 - I'm experiencing the same issue although I'd be happy with the version being 2.0.0 (ignoring the development string)

The good news is there's a workaround. You can specify your own version with the PHANTOMJS2_VERSION env

var phantomVersion = process.env.PHANTOMJS2_VERSION || helper.version

@ghost
Copy link

ghost commented Jan 16, 2016

+1 for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants