Bad version value prevents local phantom install#5
Open
jessejacob wants to merge 1 commit intogskachkov:masterfrom
Open
Bad version value prevents local phantom install#5jessejacob wants to merge 1 commit intogskachkov:masterfrom
jessejacob wants to merge 1 commit intogskachkov:masterfrom
Conversation
This property is referred to by install.js as helper.version for comparison against the 'phantomjs.exe --version' result retrieved from the copy(s) found in the system path. The version currently being downloaded by the app is '2.0.0 (development)', so currently if you install the release version and just copy the downloaded phantomjs.exe into a folder in your path, when it finds it the install.js incorrectly reports that it's the wrong version because it's expecting the output to be '2.0.0-20141016'. I personally think there needs to be a more complicated evaluation rather than an exact match, so that any 2.x version would work, but this will suffice for now.
|
+1 - I'm experiencing the same issue although I'd be happy with the version being 2.0.0 (ignoring the development string) The good news is there's a workaround. You can specify your own version with the var phantomVersion = process.env.PHANTOMJS2_VERSION || helper.version |
|
+1 for me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This property is referred to by install.js as helper.version for comparison against the 'phantomjs.exe --version' result retrieved from
the copy(s) found in the system path. The version currently being downloaded by the app is '2.0.0 (development)', so currently if you
install the release version and just copy the downloaded phantomjs.exe into a folder in your path, when it finds it the install.js incorrectly
reports that it's the wrong version because it's expecting the output to be '2.0.0-20141016'. I personally think there needs to be a more
complicated evaluation rather than an exact match, so that any 2.x version would work, but this will suffice for now.