fix: validate ICMP ID per socket, fix dual-stack ID mismatch#15
Merged
gsnw-sebast merged 1 commit intomainfrom Mar 28, 2026
Merged
fix: validate ICMP ID per socket, fix dual-stack ID mismatch#15gsnw-sebast merged 1 commit intomainfrom
gsnw-sebast merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three related bugs around ICMP echo identifier handling:
recv_ping()did not filter incoming packets by expected ID.In
SOCK_DGRAMmode the Linux kernel overwrites the ICMP identifier withthe port number assigned by
bind(), so a post-call check against aself-chosen process ID would silently discard all legitimate replies or
accept replies from other processes.
pinger.rs tracked a single
my_idfor both sockets viadgram_id4.or(dgram_id6). In dual-stack operation eachSOCK_DGRAMsocketreceives its own independent kernel-assigned port; collapsing them into
one value caused all IPv6 echo replies to be rejected because their
assigned ID differed from the IPv4 one stored in my_id.
build_icmp_packet()was called with the now-removed sharedmy_idinstead of the per-address-family ID, so sent packets already carried
the wrong identifier before any reply was received.