Skip to content

fix: remove unreachable negative-ms branch in sprint_tm#16

Merged
gsnw-sebast merged 1 commit intomainfrom
change-sprinttm
Mar 29, 2026
Merged

fix: remove unreachable negative-ms branch in sprint_tm#16
gsnw-sebast merged 1 commit intomainfrom
change-sprinttm

Conversation

@gsnw-sebast
Copy link
Copy Markdown
Contributor

Duration::as_secs_f64() is guaranteed to be >= 0.0 because Duration is
an unsigned type in Rust. The first branch in sprint_tm that handled
ms < 0.0 was therefore dead code that could never be reached at runtime.

@gsnw-sebast gsnw-sebast merged commit ba78745 into main Mar 29, 2026
2 checks passed
@gsnw-sebast gsnw-sebast deleted the change-sprinttm branch March 29, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant