Skip to content

Add optional timeout#9

Open
Traxmaxx wants to merge 1 commit into
gtramontina:masterfrom
meltwater:timeout
Open

Add optional timeout#9
Traxmaxx wants to merge 1 commit into
gtramontina:masterfrom
meltwater:timeout

Conversation

@Traxmaxx

Copy link
Copy Markdown
Contributor

Added an optional timeout value so that current implementations will not break.
Any idea how to test this properly?

@gtramontina

Copy link
Copy Markdown
Owner

Hey there,
Just to give you an update on this PR... I'm working a bit more on it as the flash function can be used with a single parameter (flash('Done!')) and supporting flash('Done!', 2000) would be desired as well...

I'm also looking into using angular's $timeout.flush() for testing...

@Traxmaxx

Copy link
Copy Markdown
Contributor Author

Good stuff! Let me know if you need anything.

@Traxmaxx

Copy link
Copy Markdown
Contributor Author

Heya,
any update on the flash timeout?

@gtramontina

Copy link
Copy Markdown
Owner

Hey! Sorry about that!
I actually got the single and multiple parameters working but was facing some problems with the $timeout.flush() when testing... Then I got swamped with work and end up not coming back to it. I'll try to push something up tonight (PST)!

@Traxmaxx

Copy link
Copy Markdown
Contributor Author

No worries, take your time : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants