Conversation
|
aug24
added
the
maintenance
aug24
force-pushed
the
test-removal-of-nvmrc
branch
from
787dd1f to
51c1e15
Compare
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: '.nvmrc' |
There was a problem hiding this comment.
Why has this line (and the same from ci.yaml below) been removed, but similar lines in other files have been updated?
There was a problem hiding this comment.
I originally changed all the lines, then deleted the lines when I was proving the process worked without any specification - I should have removed them all at the end. I'll do that now.
There was a problem hiding this comment.
Without setting node-version-file the action appears to use Node 20. I'm not sure how it chose that version, but we can see it in the build log:
I think we should be setting the value explicitly to remain deterministic.
aug24
force-pushed
the
test-removal-of-nvmrc
branch
from
775a4a2 to
0f4380c
Compare
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: '.nvmrc' |
There was a problem hiding this comment.
Without setting node-version-file the action appears to use Node 20. I'm not sure how it chose that version, but we can see it in the build log:
I think we should be setting the value explicitly to remain deterministic.
2 participants
What does this change?
Test removal of .nvmrc in favour of .tool-versions
How to test
How can we measure success?
Have we considered potential risks?
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩