Open
Conversation
This was done to to eliminate compiler errors on Ubuntu 16.04 and GCC 5.4.
Owner
|
inline can make the code more efficient |
Author
|
Yes, I understand but it doesn't compile on gcc 5.4.
If you want these functions to explicitly be inlined, you must move them to
the header file. Otherwise, you can leave it up to the compiler/linker
which may anyway inline these function calls during optimization.
…On Fri, Feb 24, 2017 at 2:54 AM, guluchen ***@***.***> wrote:
inline can make the code more efficient
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/APaYFaJrAEGcyjHpiA6dKcBqKWXS2Q-Hks5rfrcDgaJpZM4MJWf7>
.
|
Owner
|
I see. Isn't it sufficient to only remove the inline annotations in the .c files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done to to eliminate compiler errors on Ubuntu 16.04 and GCC 5.4.