forked from fullsend-ai/fullsend
-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(#195): add silent-failure severity escalation guidance #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fullsend-ai-coder
wants to merge
1
commit into
main
from
agent/195-silent-failure-severity-escalation
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] internal-consistency
The SKILL.md silent-failure bullet covers "silently produces wrong results or skips critical work" while the authoritative correctness.md version covers "silently produces wrong results, returns stale or incorrect data, or skips critical work." The omission of "returns stale or incorrect data" narrows the SKILL.md rule: a standalone code review using SKILL.md could rate a stale-data-without-error-signal finding as low, while the same finding in a PR review (using correctness.md) would be escalated to medium or higher. Since stale data returned silently is precisely the class of bug this PR targets (the annotated-tag issue returned a stale/incorrect SHA with no error), the SKILL.md version should include the same qualifying condition.
Suggested fix: Add "returns stale or incorrect data" to the SKILL.md bullet so it reads: "When a code path silently produces wrong results, returns stale or incorrect data, or skips critical work without any error signal, rate the finding medium or higher..."