docs(#346): add secure HTTP client guidance to Go section - #383
docs(#346): add secure HTTP client guidance to Go section#383fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a "Secure HTTP clients" subsection under "Go code" in AGENTS.md documenting five required security properties for any new HTTP client that fetches external URLs: SSRF-safe dialer using netutil.CheckIP, HTTPS-only with redirect validation, no proxy, explicit timeout, and bounded reads via io.LimitReader. These patterns prevent the class of review-round fixes seen in PR fullsend-ai#3002. Closes #346
|
🤖 Finished Review · ✅ Success · Started 6:48 AM UTC · Completed 6:54 AM UTC |
Review — PR #383Verdict: Approve SummaryThis PR adds a well-crafted "Secure HTTP clients" subsection under "Go code" in AGENTS.md, documenting five required security properties for any new HTTP client that fetches external URLs. The change delivers exactly what issue #346 authorized with no scope creep. Dimension results
Labels: PR adds security-related documentation guidance to AGENTS.md |
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 7:58 AM UTC · Completed 8:03 AM UTC |
🔧 Fix agent — iteration 1 (human-triggered)No changes made. The review agent approved this PR with no findings. The human /fs-fix command included no specific instruction. There are no actionable items to fix. Disagreed (1):
Tests: passed Updated by fullsend fix agent |
Add a "Secure HTTP clients" subsection under "Go code" in AGENTS.md documenting five required security properties for any new HTTP client that fetches external URLs: SSRF-safe dialer using netutil.CheckIP, HTTPS-only with redirect validation, no proxy, explicit timeout, and bounded reads via io.LimitReader. These patterns prevent the class of review-round fixes seen in PR fullsend-ai#3002.
Closes #346
Post-script verification
agent/346-secure-http-client-guidance)a2afa8b179a351845733c680b839a39a82304db6..HEAD)