Skip to content

fix(#825): remove dead defaults.auto_merge config field - #855

Open
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
agent/825-remove-dead-auto-merge
Open

fix(#825): remove dead defaults.auto_merge config field#855
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
agent/825-remove-dead-auto-merge

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Summary

  • Remove the dead defaults.auto_merge config field (RepoDefaults.AutoMerge) which was declared, defaulted, parsed, and tested but never consumed to gate any merge behavior
  • Clean up references across Go structs/tests, web admin TypeScript types, YAML fixtures, and ADR 0045
  • Existing config.yaml files containing auto_merge continue to parse without error (yaml.v3 silently ignores unknown keys)

Test plan

  • Go tests pass for internal/config (95.5% coverage) and internal/layers (84.9% coverage)
  • go vet passes on affected packages
  • Secret scan passes on all modified files
  • TypeScript tests (vitest) — not runnable in sandbox (no node_modules); changes are trivial fixture updates
  • Pre-commit — not runnable in sandbox (network-restricted); deferred to post-script

Closes #825

Post-script verification

  • Branch is not main/master (agent/825-remove-dead-auto-merge)
  • Secret scan passed (gitleaks — c887fc47c59d8b87b5282ca44044d2933d30df41..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

RepoDefaults.AutoMerge was declared, defaulted, parsed, and
tested but never consumed to gate any merge behavior. Remove
the field from the Go struct, constructor, test fixtures, web
admin TypeScript type, YAML fixtures, and ADR 0045 reference
table.

Existing config.yaml files containing auto_merge will continue
to parse without error — yaml.v3 silently ignores unknown keys.

Note: pre-commit could not run in the sandbox (network-restricted).
TypeScript tests could not run (no node_modules in sandbox).
Go tests for config and layers packages passed.

Closes #825
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 2, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:59 AM UTC · Completed 9:11 AM UTC
Commit: 205f1d5 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 2, 2026

Copy link
Copy Markdown

Looks good to me

Previous run

Looks good to me

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Aug 2, 2026
@guyoron1

guyoron1 commented Aug 2, 2026

Copy link
Copy Markdown
Owner

/fs-fix

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 2, 2026

Copy link
Copy Markdown
Author

🤖 Finished Fix · ✅ Success · Started 10:31 AM UTC · Completed 10:36 AM UTC
Commit: 205f1d5 · View workflow run →

Remove blank lines left between max_implementation_retries and agents
keys in two test YAML blocks after auto_merge field removal.

Addresses review feedback on #855
@fullsend-ai-coder

Copy link
Copy Markdown
Author

🔧 Fix agent — iteration 1 (human-triggered)

Addressed 1 review finding: removed stray blank lines in enrollment_test.go YAML fixtures left after auto_merge field removal.

Fixed (1):

  1. test-data-formatting: blank lines left in test YAML after removing auto_merge (internal/layers/enrollment_test.go): Removed blank lines at lines 237 and 307 between max_implementation_retries and agents keys, matching the formatting of other YAML fixtures in this PR

Tests: passed

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 2, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:40 AM UTC · Completed 10:51 AM UTC
Commit: 89d78f0 · View workflow run →

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity in the last month. It will be closed in 2 weeks if no further activity occurs. Remove the stale label to reset the inactivity timer.

@github-actions github-actions Bot added the stale label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal/config: defaults.auto_merge is parsed but never consumed

1 participant