fix(#825): remove dead defaults.auto_merge config field - #855
fix(#825): remove dead defaults.auto_merge config field#855fullsend-ai-coder[bot] wants to merge 2 commits into
Conversation
RepoDefaults.AutoMerge was declared, defaulted, parsed, and tested but never consumed to gate any merge behavior. Remove the field from the Go struct, constructor, test fixtures, web admin TypeScript type, YAML fixtures, and ADR 0045 reference table. Existing config.yaml files containing auto_merge will continue to parse without error — yaml.v3 silently ignores unknown keys. Note: pre-commit could not run in the sandbox (network-restricted). TypeScript tests could not run (no node_modules in sandbox). Go tests for config and layers packages passed. Closes #825
|
🤖 Finished Review · ✅ Success · Started 8:59 AM UTC · Completed 9:11 AM UTC |
|
Looks good to me Previous runLooks good to me |
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 10:31 AM UTC · Completed 10:36 AM UTC |
Remove blank lines left between max_implementation_retries and agents keys in two test YAML blocks after auto_merge field removal. Addresses review feedback on #855
🔧 Fix agent — iteration 1 (human-triggered)Addressed 1 review finding: removed stray blank lines in enrollment_test.go YAML fixtures left after auto_merge field removal. Fixed (1):
Tests: passedNext steps:
|
|
🤖 Finished Review · ✅ Success · Started 10:40 AM UTC · Completed 10:51 AM UTC |
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. It will be closed in 2 weeks if no further activity occurs. Remove the |
Summary
defaults.auto_mergeconfig field (RepoDefaults.AutoMerge) which was declared, defaulted, parsed, and tested but never consumed to gate any merge behaviorconfig.yamlfiles containingauto_mergecontinue to parse without error (yaml.v3 silently ignores unknown keys)Test plan
internal/config(95.5% coverage) andinternal/layers(84.9% coverage)go vetpasses on affected packagesCloses #825
Post-script verification
agent/825-remove-dead-auto-merge)c887fc47c59d8b87b5282ca44044d2933d30df41..HEAD)