Skip to content

docs(#842): instruct agents to verify non-diff claims against base branch - #867

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/842-base-branch-verification
Open

docs(#842): instruct agents to verify non-diff claims against base branch#867
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/842-base-branch-verification

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Summary

Adds base-branch verification guidance to the scaffold AGENTS.md so that agents (especially the fix agent) verify claims about files not in the PR diff against origin/main rather than the potentially stale PR branch.

Related Issue

Fixes #842

Changes

  • Extended section 1 ("Think before acting") of internal/scaffold/fullsend-repo/AGENTS.md with a new paragraph instructing agents to use the base branch when verifying claims about files not in the PR diff
  • Includes a concrete git show origin/main:<path> command example for reading the current version of a file from the base ref

Testing

  • Scaffold package tests pass (go test ./internal/scaffold/...)
  • go vet ./... passes
  • No secrets detected (scan-secrets)
  • make lint could not run (pre-commit network 403 in sandbox — post-script runs authoritatively)

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Commits are signed off (DCO) — human and human-directed agent sessions only
  • I wrote this contribution myself and can explain all changes in it

Closes #842

Post-script verification

  • Branch is not main/master (agent/842-base-branch-verification)
  • Secret scan passed (gitleaks — c887fc47c59d8b87b5282ca44044d2933d30df41..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

…anch

The scaffold AGENTS.md section 1 ("Think before acting") tells agents
to verify claims against the actual codebase, but does not specify
which branch to use. When a PR branch has diverged significantly from
main, the agent's checkout contains stale copies of files the PR did
not modify. A fix agent reading such a stale file can incorrectly
disagree with an accurate review finding.

Add a paragraph to section 1 instructing agents to use the base
branch (origin/main or the PR merge target) when verifying claims
about files not in the PR diff. Includes the concrete git-show
command to read a file from the base ref.

Note: pre-commit could not run in sandbox (network 403).

Closes #842
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 2, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:45 AM UTC · Completed 9:51 AM UTC
Commit: a5792e1 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: PR modifies scaffold documentation (internal/scaffold/fullsend-repo/AGENTS.md)

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge documentation Improvements or additions to documentation labels Aug 2, 2026
@guyoron1

guyoron1 commented Aug 2, 2026

Copy link
Copy Markdown
Owner

/fs-fix

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 2, 2026

Copy link
Copy Markdown
Author

🤖 Finished Fix · ✅ Success · Started 10:32 AM UTC · Completed 10:37 AM UTC
Commit: a5792e1 · View workflow run →

@fullsend-ai-coder

Copy link
Copy Markdown
Author

🔧 Fix agent — iteration 1 (human-triggered)

No fixes needed. The review bot approved the PR with no findings, and the human /fs-fix command included no specific instruction. Verified: scaffold tests pass, go vet clean, no secrets detected. The PR correctly adds base-branch verification guidance to the scaffold AGENTS.md.

Disagreed (1):

  1. No actionable review findings or human instruction: The review bot approved this PR with 'Looks good to me' and no findings were raised. The human triggered /fs-fix without any specific instruction (HUMAN_INSTRUCTION=none). The PR diff is clean: it adds well-written base-branch verification guidance to the scaffold AGENTS.md, correctly addressing issue Fix agent should verify codebase-state claims against the base branch before disagreeing #842. Tests pass (go test ./internal/scaffold/...), go vet is clean, and no secrets were detected. There are no code changes to make.

Tests: passed

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity in the last month. It will be closed in 2 weeks if no further activity occurs. Remove the stale label to reset the inactivity timer.

@github-actions github-actions Bot added the stale label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready-for-merge All reviewers approved — ready to merge stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix agent should verify codebase-state claims against the base branch before disagreeing

1 participant