docs(#842): instruct agents to verify non-diff claims against base branch - #867
docs(#842): instruct agents to verify non-diff claims against base branch#867fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…anch
The scaffold AGENTS.md section 1 ("Think before acting") tells agents
to verify claims against the actual codebase, but does not specify
which branch to use. When a PR branch has diverged significantly from
main, the agent's checkout contains stale copies of files the PR did
not modify. A fix agent reading such a stale file can incorrectly
disagree with an accurate review finding.
Add a paragraph to section 1 instructing agents to use the base
branch (origin/main or the PR merge target) when verifying claims
about files not in the PR diff. Includes the concrete git-show
command to read a file from the base ref.
Note: pre-commit could not run in sandbox (network 403).
Closes #842
|
🤖 Finished Review · ✅ Success · Started 9:45 AM UTC · Completed 9:51 AM UTC |
|
Looks good to me Labels: PR modifies scaffold documentation (internal/scaffold/fullsend-repo/AGENTS.md) |
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 10:32 AM UTC · Completed 10:37 AM UTC |
🔧 Fix agent — iteration 1 (human-triggered)No fixes needed. The review bot approved the PR with no findings, and the human /fs-fix command included no specific instruction. Verified: scaffold tests pass, go vet clean, no secrets detected. The PR correctly adds base-branch verification guidance to the scaffold AGENTS.md. Disagreed (1):
Tests: passedNext steps:
|
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. It will be closed in 2 weeks if no further activity occurs. Remove the |
Summary
Adds base-branch verification guidance to the scaffold AGENTS.md so that agents (especially the fix agent) verify claims about files not in the PR diff against
origin/mainrather than the potentially stale PR branch.Related Issue
Fixes #842
Changes
internal/scaffold/fullsend-repo/AGENTS.mdwith a new paragraph instructing agents to use the base branch when verifying claims about files not in the PR diffgit show origin/main:<path>command example for reading the current version of a file from the base refTesting
go test ./internal/scaffold/...)go vet ./...passesscan-secrets)make lintcould not run (pre-commit network 403 in sandbox — post-script runs authoritatively)Checklist
!for breaking changes)Closes #842
Post-script verification
agent/842-base-branch-verification)c887fc47c59d8b87b5282ca44044d2933d30df41..HEAD)