Add support for GWpy 4.0.0#182
Merged
Merged
Conversation
duncanmmacleod
force-pushed
the
gwpy-4
branch
from
February 27, 2026 10:47
e370934 to
7a3e458
Compare
duncanmmacleod
marked this pull request as draft
February 27, 2026 12:44
GWpy 4.x is stricter (worse) at recognising segwizard files than before
GWpy 4.0.0 returns aware datetime's, including timezone information, so the default output representation is different; the easiest solution is to control it explicitly so there are no surprises
The I/O registry construction in GWpy 4.0.0 changed, and the get_read_format function was removed, so we rebuild it by calling out to the private method that it used to call
The package_list function makes an actual system call, and requires either conda or pip to be available on the system - this commit patches that out to avoid an unnecessary requirement. uv creates virtualenvs without pip by default, so this should avoid any surprises.
duncanmmacleod
force-pushed
the
gwpy-4
branch
from
February 28, 2026 17:29
7a3e458 to
93a4144
Compare
duncanmmacleod
marked this pull request as ready for review
February 28, 2026 17:29
Contributor
|
I've tested a full run of HVeto with this patch and gwpy=4.0.1. Things ran to completion with the expected science output. One deprecation warning did appear that should be addressed in a future PR: My test HVeto run can be found here (requires LIGO.org authentication): https://ldas-jobs.ligo-la.caltech.edu/~derek.davis/detchar/O4/hveto/250210/ |
Contributor
|
Output looks good to me, thank you both! |
areeda
pushed a commit
to areeda/hveto
that referenced
this pull request
Jul 15, 2026
* fix(segments): Use explicit format=segwizard when reading segments GWpy 4.x is stricter (worse) at recognising segwizard files than before * fix(html): Explicitly control datetime format for HTML GWpy 4.0.0 returns aware datetime's, including timezone information, so the default output representation is different; the easiest solution is to control it explicitly so there are no surprises * fix(triggers): Update trigger reading for GWpy 4.0.0 The I/O registry construction in GWpy 4.0.0 changed, and the get_read_format function was removed, so we rebuild it by calling out to the private method that it used to call * test: Mock out package_list() in HTML tests The package_list function makes an actual system call, and requires either conda or pip to be available on the system - this commit patches that out to avoid an unnecessary requirement. uv creates virtualenvs without pip by default, so this should avoid any surprises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GWpy 4.0.0rc1 has been released, and includes a number of breaking changes that impact this project. This PR includes patches to fix the test suite when installed alongside the new GWpy.
I have not tested an actual Hveto run, so there could easily be more to fix.