LSF job state#429
Merged
Merged
Conversation
…_job_states to only get current jobs, like SLURM
Collaborator
|
Thanks a lot, Tom! Cool to see that gwf is in use at Sanger :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current approach of creating a subprocess to run and capture the output of
bjobs <jobid>for every tracked job is very slow when dealing with large numbers of targets.Calling
bjobswill only return Submitted, Suspended, Running and Unknown jobs, so this does remove the ability to capture Failed jobs - although, this information is only returned frombjobs <jobid>in a very short window after the jobs has finished, so in practice I think this is the better approach overall.Changes:
Tested on the LSF HPC at the Wellcome Sanger Institute
Thanks for your work on GWF!