Skip to content

Update segments module to handle incoming changes from gwpy DataQualityDict updates#417

Open
eagoetz wants to merge 3 commits into
gwpy:masterfrom
eagoetz:rename-url-host
Open

Update segments module to handle incoming changes from gwpy DataQualityDict updates#417
eagoetz wants to merge 3 commits into
gwpy:masterfrom
eagoetz:rename-url-host

Conversation

@eagoetz

@eagoetz eagoetz commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

This PR updates the segments module to handle changes to the gwpy.DataQualityDict API changing url keyword to host.

Also some minor clean up of the code and setting new version pins.

This PR is draft pending tests

@eagoetz eagoetz self-assigned this Dec 5, 2024
@eagoetz eagoetz added this to the 2.3.0 milestone Dec 5, 2024
@eagoetz
eagoetz force-pushed the rename-url-host branch 3 times, most recently from 6380af5 to 332d620 Compare December 13, 2024 18:49
@codecov

codecov Bot commented Dec 13, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.26%. Comparing base (8853e24) to head (c3b0eaa).

Files with missing lines Patch % Lines
gwsumm/segments.py 80.00% 2 Missing ⚠️
gwsumm/state/core.py 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   49.26%   49.26%   -0.00%     
==========================================
  Files          60       60              
  Lines        8806     8792      -14     
==========================================
- Hits         4338     4331       -7     
+ Misses       4468     4461       -7     
Flag Coverage Δ
Linux-python3.10 ?
Linux-python3.11 49.26% <75.00%> (+0.02%) ⬆️
Linux-python3.12 49.26% <75.00%> (?)
Linux-python3.13 49.26% <75.00%> (?)
macOS-python3.10 ?
macOS-python3.11 49.26% <75.00%> (+0.02%) ⬆️
macOS-python3.12 49.26% <75.00%> (?)
macOS-python3.13 49.26% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eagoetz eagoetz modified the milestones: 2.3.0, 2.3.1 Apr 28, 2025
@eagoetz eagoetz modified the milestones: 2.3.1, 2.4.0 May 7, 2025
@eagoetz eagoetz modified the milestones: 2.4.0, 2.4.1 Nov 25, 2025
@eagoetz
eagoetz force-pushed the rename-url-host branch from 6747729 to de07b27 Compare May 14, 2026 17:47
@eagoetz
eagoetz force-pushed the rename-url-host branch from 08bd1c5 to 58f642b Compare May 14, 2026 22:16
@eagoetz
eagoetz force-pushed the rename-url-host branch from 5edd0f7 to c3b0eaa Compare May 14, 2026 23:00
@eagoetz
eagoetz marked this pull request as ready for review May 14, 2026 23:54
@eagoetz eagoetz modified the milestones: 2.4.1, 2.5.0 May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant