Fix SEI watchdog plotting (data access issue)#451
Merged
Conversation
The SeiWatchDogPlot.draw() class method accesses data (oof) and may end up trying to access data beyond the end of the frame cache because the current class initialization uses an int() truncation to the GPS time used for the centre of the plot range. This sometimes results in an incorrect frame cache that the reading of data is a different range. To fix this, we use floor and ceil to make sure the full range of data is selected
eagoetz
force-pushed
the
fix-sei-watchdog
branch
from
July 16, 2026 16:31
70ea9a8 to
c003374
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 49.24% 49.25% +0.01%
==========================================
Files 60 60
Lines 8810 8811 +1
==========================================
+ Hits 4338 4339 +1
Misses 4472 4472
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SeiWatchDogPlot.draw() class method accesses data (oof) and may end up trying to access data beyond the end of the frame cache because the current class initialization uses an int() truncation to the GPS time used for the centre of the plot range. This sometimes results in an incorrect frame cache that the reading of data is a different range.
To fix this, we use floor and ceil to make sure the full range of data is selected