Skip to content

Set OMICRON_HTML in omicron.utils.get_omicron_version#174

Merged
areeda merged 1 commit into
gwpy:masterfrom
duncanmmacleod:OMICRON_HTML
Oct 28, 2023
Merged

Set OMICRON_HTML in omicron.utils.get_omicron_version#174
areeda merged 1 commit into
gwpy:masterfrom
duncanmmacleod:OMICRON_HTML

Conversation

@duncanmmacleod

Copy link
Copy Markdown
Member

This PR patches omicron.utils.get_omicron_version() to always set OMICRON_HTML (to gettempdir()) to avoid a segfault.

@codecov

codecov Bot commented Oct 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #174 (25f4126) into master (62e4c52) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   35.12%   35.15%   +0.02%     
==========================================
  Files          30       30              
  Lines        2941     2942       +1     
==========================================
+ Hits         1033     1034       +1     
  Misses       1908     1908              
Flag Coverage Δ
Conda 35.15% <100.00%> (+0.02%) ⬆️
Linux 35.15% <100.00%> (+0.02%) ⬆️
macOS 35.15% <100.00%> (+0.02%) ⬆️
python3.10 35.15% <100.00%> (+0.02%) ⬆️
python3.11 35.15% <100.00%> (+0.02%) ⬆️
python3.9 35.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
omicron/utils.py 81.08% <100.00%> (+0.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@duncanmmacleod duncanmmacleod added this to the pyomicron 2.0.7 milestone Oct 27, 2023
@areeda

areeda commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator

I don't understand why we have these flake8 problems.
If on my mac I do

git fetch upstream master
git switch upstream/master
git switch -c upstream_master
flake8

I get no complaints. My repositories are:

$ gre -v
origin	git@github.com:areeda/pyomicron.git (fetch)
origin	git@github.com:areeda/pyomicron.git (push)
upstream	git@github.com:gwpy/pyomicron.git (fetch)
upstream	git@github.com:gwpy/pyomicron.git (push)

Can you see what I'm missing?
..edit..
I also did a git clone of the repo and flake8 was silent. I have not quieted the whitespace around operators (for example)

@duncanmmacleod

Copy link
Copy Markdown
Member Author

The flake8 complaints are only visible using Python >=3.12, but are fixed by #175.

@areeda

areeda commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

Thanks

@areeda
areeda merged commit 360a252 into gwpy:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants