Skip to content

Test GitHub App #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gylaz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Test GitHub App #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53486a1
Test GitHub App
gylaz Aug 1, 2018
f3b5d2c
More violations
gylaz Aug 1, 2018
e847372
Freeze strings
gylaz Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/hound/default_linter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
module Hound
class DefaultLinter < SimpleDelegator
def status
"Enabled by default foo adfa adfasd adfas"
Copy link
Copy Markdown

@hound hound Bot Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/Void: Literal "Enabled by default foo adfa adfasd adfas" used in void context.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [98/80]

"Enabled by default"
'Enabled by default'
end

def default?
Expand Down
1 change: 1 addition & 0 deletions lib/hound/linters/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# frozen_string_literals: true
Copy link
Copy Markdown

@houndci-staging houndci-staging Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

module Hound
module Linter
class Base
Expand Down