Refactor errors - #3
Merged
Merged
Conversation
…n errors Remove the FieldError wrapper type that was creating redundant wrapping of errors that already contained field context. Instead, thread fieldName through the decode chain so each error type is self-contained with complete context (struct field name + type info + underlying cause), following the os.PathError pattern. Key changes: - Remove FieldError struct and all wrapping in populate.go - Add fieldName to entry struct and thread it through handleField and decode functions - Add Filepath field to OpenFileError for consistency with FileReadError - Add FieldName field to UnsupportedFieldTypeError - Simplify MalformedTagError and MalformedDefaultError Unwrap() methods - Update error message formatting to use %q for identifiers (field names) - Move ErrSyntax into the sentinel vars block - Update all error tests and error message expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.