Convert Logic App template to use Azure Verified Modules#18
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Co-authored-by: h2floh <29010283+h2floh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Integration] LogicApps Template
Add Logic App template for SAP to SQL Database integration
Aug 4, 2025
h2floh
requested changes
Aug 6, 2025
| var servicePlanName = 'asp-${uniqueSuffix}' | ||
|
|
||
| // Storage Account for Logic App Standard | ||
| resource storageAccount 'Microsoft.Storage/storageAccounts@2023-01-01' = { |
Owner
There was a problem hiding this comment.
@copilot mach das mal bitte lieber mit Azure Verified Modules
Contributor
Author
There was a problem hiding this comment.
I've converted the logicapp.bicep file to use Azure Verified Modules as requested. The changes include:
- Storage Account: Now uses
br/public:avm/res/storage/storage-account:0.6.7 - App Service Plan: Now uses
br/public:avm/res/web/serverfarm:0.4.1 - Logic App: Now uses
br/public:avm/res/web/site:0.11.0
SQL Server and Database remain as native Azure resources since AVM modules for SQL aren't available yet. All references have been updated to use module outputs instead of resource properties.
Commit: 963512d
… service plan, and logic app Co-authored-by: h2floh <29010283+h2floh@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add Logic App template for SAP to SQL Database integration
Convert Logic App template to use Azure Verified Modules
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the Logic App SAP to SQL Database integration template to use Azure Verified Modules (AVM) instead of native Azure resource definitions, following Microsoft's best practices for infrastructure as code.
Changes Made
Azure Verified Modules Implementation:
br/public:avm/res/storage/storage-account:0.6.7with proper parameter mappingbr/public:avm/res/web/serverfarm:0.4.1maintaining WorkflowStandard configurationbr/public:avm/res/web/site:0.11.0withfunctionapp,workflowappkindNative Resources Retained:
Reference Updates:
storageAccount.outputs.name,servicePlan.outputs.resourceId, etc.)Technical Benefits
The conversion provides:
All functionality remains identical while adopting the repository's established AVM patterns for better long-term maintenance and compliance with Azure Well-Architected Framework principles.
Fixes #16.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.