Skip to content

Fixes undefined variables (tmp, pathToCopy, pane...) #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JasperLorelai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes undefined variables (tmp, pathToCopy, pane...) #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/ftp-remote-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,11 +1902,7 @@ class FtpRemoteEdit {
if (selected.length === 0) return;

let element = selected.view();
if (element.is('.directory')) {
pathToCopy = element.getPath(true);
} else {
pathToCopy = element.getPath(true) + element.name;
}
let pathToCopy = element.getPath(true) + (element.is('.directory') ? "" : element.name);
atom.clipboard.write(pathToCopy)
}

Expand Down
2 changes: 1 addition & 1 deletion lib/helper/finder-items-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class FinderItemsCache extends EventEmitter {
try {
if (FileSystem.existsSync(file)) {
let tmp = FileSystem.readFileSync(file);
cache = JSON.parse(tmp);
let cache = JSON.parse(tmp);
self.paths = cache.paths;
self.items = cache.items;
return true;
Expand Down
2 changes: 1 addition & 1 deletion lib/helper/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ export const getTextEditor = (pathOnFileSystem, activate = false) => {
});

if (activate && foundEditor) {
pane = atom.workspace.paneForItem(foundEditor);
let pane = atom.workspace.paneForItem(foundEditor);
if (pane) pane.activateItem(foundEditor);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/views/tree-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ class TreeView extends ScrollView {
let next = current.find('.entries .entry:visible');

if (!next.length) {
tmp = current;
let tmp = current;

// Workaround skip after 10
let counter = 1;
Expand Down