Skip to content

Ensure small/large angle approximation flag used for error maps - #140

Open
lukeje wants to merge 4 commits into
masterfrom
fix_errormap-smallangleapproximation
Open

Ensure small/large angle approximation flag used for error maps#140
lukeje wants to merge 4 commits into
masterfrom
fix_errormap-smallangleapproximation

Conversation

@lukeje

@lukeje lukeje commented Aug 5, 2026

Copy link
Copy Markdown
Member

The check for the small angle approximation flag was within another if statement which checked for the presence of a flip angle map, and so could unintentionally be skipped. This is fixed by the current pull request. I also took the liberty of correcting some typos, formatting issues and inconsistencies in the documentation for these functions.

This bug will have given rise to incorrect error maps in the case where the toolbox was run with small_angle_approximation=false and with either the UNICORT option or no supplied transmit B1 field map. In this case the error maps would be incorrect and so map creation should be rerun after applying this fix.

@lukeje
lukeje requested a review from Barisevrenugur August 5, 2026 15:02
@lukeje

lukeje commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@Barisevrenugur I assigned this to you to get a second pair of eyes on it before pulling. I hope it's pretty simple; let me know if you don't have time so I can ask someone else.

@Barisevrenugur

Copy link
Copy Markdown
Contributor

@lukeje I am working to finish up other things but yes I can give a look to this one, the code change is not very extensive. but in a nutshell the code change is the following right? : if there is no B1 correction (f_T is empty) the small angle approximation is still applied, in the case when f_T is not empty (there is B1 correction), current change gives the same execution flow with the previous code

@Barisevrenugur I assigned this to you to get a second pair of eyes on it before pulling. I hope it's pretty simple; let me know if you don't have time so I can ask someone else.

@lukeje lukeje added bug Something isn't working createMaps assoc. to create maps module labels Aug 10, 2026
@lukeje
lukeje requested a review from siawoosh August 11, 2026 13:12
@lukeje

lukeje commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

@siawoosh I've added you as a reviewer so that you are made aware of this bug. I can't even remember why we might have implemented it with the small angle check inside the B1 map check...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working createMaps assoc. to create maps module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants