Skip to content

Bundle PR review helpers for portable use - #210

Merged
haacked merged 1 commit into
mainfrom
haacked/portable-pr-review-wait
Sep 15, 2026
Merged

haacked merged 1 commit into
mainfrom
haacked/portable-pr-review-wait

Conversation

@haacked

@haacked haacked commented Sep 15, 2026

Copy link
Copy Markdown
Owner
  • Bundle PR detection and polling helpers with wait-for-pr-reviews so copied skill directories can resolve PRs and check reviewer state.
  • Add a sync script and CI check that keep four bundled helpers aligned with bin/, including executable permissions.
  • Document that comment processing still requires address-pr-reviews and its runtime dependencies.

Test plan

  • Run 9 isolated copied-skill tests.
  • Run 36 pending-review verdict tests and 23 Copilot helper tests.
  • Run 30 skill specs and 5 canonical checks.
  • Check the sync script and isolated tests with shellcheck and shfmt.
  • Verify the helper sync and diff checks.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments were identified, and the supplied assessment confirms approval readiness.

Pull request overview

Bundles portable PR detection and review-polling helpers with wait-for-pr-reviews.

Changes:

  • Added bundled helper scripts and portability tests.
  • Added synchronization tooling and CI validation.
  • Updated documentation for dependencies and maintenance.
File summaries
File Summary
ai/skills/wait-for-pr-reviews/SKILL.md Documents portable execution and dependencies.
ai/skills/wait-for-pr-reviews/scripts/wait-for-pending-reviews.sh Bundles the pending-review polling helper.
ai/skills/wait-for-pr-reviews/scripts/tests/test-portable-skill.sh Tests isolated copied-skill operation.
ai/skills/wait-for-pr-reviews/scripts/lib/logging.sh Provides bundled logging utilities.
ai/skills/wait-for-pr-reviews/scripts/lib/github.sh Provides bundled GitHub utilities.
ai/skills/wait-for-pr-reviews/scripts/git-pr Provides bundled PR resolution support.
ai/skills/wait-for-pr-reviews/scripts/detect-pr.sh Bundles PR detection logic.
ai/skills/wait-for-pr-reviews/scripts/check-pending-reviews.sh Bundles pending-review checks.
ai/README.md Documents helper bundling and maintenance.
ai/bin/sync-pr-review-helpers.sh Synchronizes helpers and executable permissions.
.github/workflows/test.yml Runs synchronization and portability checks.
Review details
  • Files reviewed: 10/11 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@haacked
haacked marked this pull request as ready for review September 15, 2026 20:50
@haacked
haacked merged commit 82e1944 into main Sep 15, 2026
2 checks passed
@haacked
haacked deleted the haacked/portable-pr-review-wait branch September 15, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants