Feature/update ffmpeg - #13
Open
SergeGris wants to merge 14 commits into
Open
Conversation
The updated repeat_stream method now: 1. Uses avio_seek() to seek the I/O layer to byte 0 (start of file) 2. Flushes I/O and format buffers with avio_flush() and avformat_flush() 3. Uses av_seek_frame() to reset the demuxer 4. Flushes decoder state with avcodec_flush_buffers() 5. Includes comprehensive comments and improved error handling This approach is more robust than pure high-level seeking and matches the FFmpeg recommended practice for stream repetition in modern versions.
Removed low-level avio_seek operations that cause segfaults. The new approach: 1. Only uses av_seek_frame with proper flags (AVSEEK_FLAG_BACKWARD) 2. Flushes decoder buffers after seeking 3. Avoids mixing low-level I/O with format context operations This is more reliable and safer across different file formats and FFmpeg versions.
hack3rmann
self-requested a review
May 7, 2026 06:08
Owner
|
|
hack3rmann
requested changes
May 7, 2026
hack3rmann
left a comment
hack3rmann
left a comment
Owner
There was a problem hiding this comment.
repeat_stream must do the same thing as before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.