added items that counts towards the event in the event shop#300
added items that counts towards the event in the event shop#300markalmax wants to merge 3 commits into
Conversation
techpixel
left a comment
There was a problem hiding this comment.
thanks for the contribution! i'm worried that this implementation changes some of the core expectations that the horizons platform has. for example, some users buying tickets might show up as not qualified as a side effect of the event hour credit operations (in other words, this might mess up our tracking for events!).
i'd recommend instead of doing a credit system, you do the math to determine the updated ticket threshold only at purchase time, so it doesn't affect other systems
|
thanks for your comment I will check it out, update the logic and put it up for review again |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
I made a couple of small but noticable changes |
please review my code just incase 🙏