Skip to content

added items that counts towards the event in the event shop#300

Open
markalmax wants to merge 3 commits into
hackclub:mainfrom
markalmax:main
Open

added items that counts towards the event in the event shop#300
markalmax wants to merge 3 commits into
hackclub:mainfrom
markalmax:main

Conversation

@markalmax

Copy link
Copy Markdown
Collaborator

please review my code just incase 🙏

@techpixel techpixel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution! i'm worried that this implementation changes some of the core expectations that the horizons platform has. for example, some users buying tickets might show up as not qualified as a side effect of the event hour credit operations (in other words, this might mess up our tracking for events!).
i'd recommend instead of doing a credit system, you do the math to determine the updated ticket threshold only at purchase time, so it doesn't affect other systems

@markalmax

Copy link
Copy Markdown
Collaborator Author

thanks for your comment I will check it out, update the logic and put it up for review again
I will make sure to note all my results when I test for bugs, expect an update to the pr within a few hours

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedmarked@​17.0.51001001009680
Addedlucide-svelte@​0.469.01001009592100
Addedloops@​6.3.010010010094100

View full report

@markalmax markalmax requested a review from techpixel June 4, 2026 10:47
@markalmax

Copy link
Copy Markdown
Collaborator Author

I made a couple of small but noticable changes
it should not cause any issues... I hope otherwise I really don't know what to do 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants