chore(mcp-server): remove the package from the monorepo - #162
Merged
Conversation
The remote Streamable-HTTP MCP server (@1c-odata/mcp-server) is not ready for release: it was never published to npm and needs more bake time. Remove it from master; the full implementation is preserved in a standing restore PR to land when it matures. Removed alongside the package tree: - CI: gates 2c/2d (auth-schema + drizzle append-only), gate 8b (Windows bin boot), deploy-pg-smoke and deploy-package-smoke jobs; none of them were required checks in the branch ruleset - Workflows: deploy-compose.yml, release-image.yml (and the publish-image job in release.yml) - Dependabot: docker/docker-compose entries for the deploy tree and the better-auth group exclusions - Root .dockerignore (only served the mcp-server image build context) - The eight unreleased mcp-server changesets; @1c-odata/mcp-server dropped from the changesets fixed group and from node-24-lts-floor.md The @1c-odata/mcp/internal seam stays (already released in 0.6.0, used by its own tests); its docs now say "a multi-tenant host" instead of naming the removed package. CLAUDE.md/README.md/STABILITY.md updated to the four-package layout.
There was a problem hiding this comment.
🟡 Changes recommended
STABILITY.md still contains a “five packages” fixed-group statement that contradicts the new four-package layout after removing @1c-odata/mcp-server.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the (unreleased) remote Streamable-HTTP MCP server package (@1c-odata/mcp-server) and its supporting CI/deploy/release automation, returning the monorepo to a four-package layout while keeping @1c-odata/mcp/internal as an “alternate host” seam.
Changes:
- Deleted
packages/mcp-server/(server implementation, deploy stack, migrations, and test suites). - Updated docs and
@1c-odata/mcpwording to remove direct references to the removed package and describe the/internalseam generically (“alternate host”). - Removed image-release / deploy-smoke workflows and pruned Dependabot docker/compose updates; updated Changesets to drop
@1c-odata/mcp-serverfrom the fixed group and preserve@1c-odata/mcpchangelog notes via a new changeset.
File summaries
| File | Description |
|---|---|
| STABILITY.md | Removes mcp-server surface docs; updates @1c-odata/mcp contract language. |
| README.md | Removes @1c-odata/mcp-server from the package list and “AI agents” description. |
| packages/mcp/test/unit/internal-surface.test.ts | Rewords internal surface test comments away from mcp-server specifics. |
| packages/mcp/test/unit/connection-source.test.ts | Rewords ConnectionSource seam motivation away from mcp-server specifics. |
| packages/mcp/src/secret-store.ts | Updates SecretSource docs to describe DB-backed sources generically. |
| packages/mcp/src/internal.ts | Updates internal subpath docs to describe “alternate hosts” generically. |
| packages/mcp/src/index.ts | Updates package header comment to remove mcp-server mention. |
| packages/mcp/src/connection-source.ts | Updates ConnectionSource docs to remove mcp-server mention. |
| packages/mcp/src/connection-pool.ts | Updates ReadPool docs to remove mcp-server mention. |
| packages/mcp-server/vitest.config.ts | Removed (package decommission). |
| packages/mcp-server/tsdown.config.ts | Removed (package decommission). |
| packages/mcp-server/tsconfig.test.json | Removed (package decommission). |
| packages/mcp-server/tsconfig.json | Removed (package decommission). |
| packages/mcp-server/test/unit/sign-in-page.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/setup-token.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/resource-metadata.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/migrate.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/mcp-route.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/cli-keyring.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/cli-allowed-hosts.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/auth-canonical-urls.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/admin-server-info.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/admin-probe-classify.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/admin-grants.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/admin-gate.test.ts | Removed (package decommission). |
| packages/mcp-server/test/unit/admin-csrf.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/setup-wizard.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/set-password.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/session-binding.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/oauth-jwt.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/mcp-endpoint.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/mcp-auth-gate.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/jwks-offline.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/admin-create.test.ts | Removed (package decommission). |
| packages/mcp-server/test/e2e/account.test.ts | Removed (package decommission). |
| packages/mcp-server/src/version.ts | Removed (package decommission). |
| packages/mcp-server/src/tenancy/scoped-pool.ts | Removed (package decommission). |
| packages/mcp-server/src/tenancy/grants.ts | Removed (package decommission). |
| packages/mcp-server/src/tenancy/db-connection-source.ts | Removed (package decommission). |
| packages/mcp-server/src/store/tenancy-schema.ts | Removed (package decommission). |
| packages/mcp-server/src/store/schema.ts | Removed (package decommission). |
| packages/mcp-server/src/store/migrate.ts | Removed (package decommission). |
| packages/mcp-server/src/store/db.ts | Removed (package decommission). |
| packages/mcp-server/src/server-factory.ts | Removed (package decommission). |
| packages/mcp-server/src/logger.ts | Removed (package decommission). |
| packages/mcp-server/src/http/discovery.ts | Removed (package decommission). |
| packages/mcp-server/src/http/auth-mount.ts | Removed (package decommission). |
| packages/mcp-server/src/http/app.ts | Removed (package decommission). |
| packages/mcp-server/src/http/admin/views.ts | Removed (package decommission). |
| packages/mcp-server/src/http/admin/server-info.ts | Removed (package decommission). |
| packages/mcp-server/src/http/admin/health-job.ts | Removed (package decommission). |
| packages/mcp-server/src/http/admin/grants.ts | Removed (package decommission). |
| packages/mcp-server/src/http/admin/dashboard.ts | Removed (package decommission). |
| packages/mcp-server/src/http/account/router.ts | Removed (package decommission). |
| packages/mcp-server/src/auth/resource-metadata.ts | Removed (package decommission). |
| packages/mcp-server/src/auth/pages/sign-in.ts | Removed (package decommission). |
| packages/mcp-server/src/auth/pages/consent.ts | Removed (package decommission). |
| packages/mcp-server/src/auth/config.ts | Removed (package decommission). |
| packages/mcp-server/package.json | Removed (package decommission). |
| packages/mcp-server/LICENSE | Removed (package decommission). |
| packages/mcp-server/drizzle/meta/_journal.json | Removed (package decommission). |
| packages/mcp-server/drizzle/0002_huge_supreme_intelligence.sql | Removed (package decommission). |
| packages/mcp-server/drizzle/0001_right_captain_marvel.sql | Removed (package decommission). |
| packages/mcp-server/drizzle.config.ts | Removed (package decommission). |
| packages/mcp-server/deploy/Dockerfile | Removed (package decommission). |
| packages/mcp-server/deploy/compose.yml | Removed (package decommission). |
| packages/mcp-server/deploy/compose.prod.yml | Removed (package decommission). |
| packages/mcp-server/deploy/ci/smoke.sh | Removed (package decommission). |
| packages/mcp-server/deploy/ci/package-smoke.sh | Removed (package decommission). |
| packages/mcp-server/deploy/ci/compose.ci.yml | Removed (package decommission). |
| packages/mcp-server/deploy/ci/compose-smoke.sh | Removed (package decommission). |
| packages/mcp-server/deploy/ci/Caddyfile.ci | Removed (package decommission). |
| packages/mcp-server/deploy/Caddyfile | Removed (package decommission). |
| packages/mcp-server/deploy/.env.example | Removed (package decommission). |
| packages/mcp-server/auth.config.ts | Removed (package decommission). |
| biome.json | Removes now-dead **/deploy/ci/** override. |
| .github/workflows/release.yml | Removes container-image publishing outputs/job wiring from the release workflow. |
| .github/workflows/release-image.yml | Removed (mcp-server image publishing workflow decommission). |
| .github/workflows/deploy-compose.yml | Removed (mcp-server deploy compose smoke workflow decommission). |
| .github/dependabot.yml | Removes docker/docker-compose update entries and updates rationale text for four packages. |
| .dockerignore | Removed (previously tailored to mcp-server Docker build context). |
| .changeset/node-24-lts-floor.md | Drops @1c-odata/mcp-server from the changeset and adjusts wording. |
| .changeset/mcp-server-multi-tenancy.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-server-jwks-read-timeout.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-server-in-process-jwks.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-server-http-transport.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-server-ghcr-image.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-server-deploy-hardening.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-server-auth-layer.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-server-admin-panel.md | Removed (mcp-server changeset decommission). |
| .changeset/mcp-internal-reexports.md | New changeset to preserve @1c-odata/mcp changelog entries previously embedded in deleted changesets. |
| .changeset/mcp-db-secret-source-and-verify-connectivity.md | Rewords to remove explicit mcp-server reference. |
| .changeset/mcp-connection-source-seam.md | Rewords to remove explicit mcp-server reference. |
| .changeset/config.json | Removes @1c-odata/mcp-server from the Changesets fixed group. |
Review details
- Files reviewed: 132/133 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟢 Approval recommended
The removed package no longer exists in-tree and repository-wide references to @1c-odata/mcp-server/packages/mcp-server have been eliminated consistently across docs, Changesets, and workflows.
Review details
- Files reviewed: 132/133 changed files
- Comments generated: 0 new
- Review effort level: Lite
This was referenced Sep 1, 2026
hacker-cb
added a commit
that referenced
this pull request
Sep 1, 2026
…166) PR #162 removed deploy-package-smoke together with @1c-odata/mcp-server, and with it the only CI coverage of the published-artifact path: nothing installed the pnpm-pack tarballs (the exact artifact release.yml publishes) or ran the bins from a consumer node_modules layout. package:lint reads manifest and types statically, so a dropped files entry, broken bin, broken exports map, or unrewritten workspace:* range would reach npm green. .ci/package-smoke.sh packs the four workspace tarballs, installs each into its own isolated scratch project (overrides pin the unpublished siblings to local tarballs; --ignore-scripts because nothing pins the third-party graph here), imports every exports entrypoint from the installed tree, and runs both bins directly via node_modules/.bin. Wired as a secret-free fork-safe package-smoke job in ci.yml, with the workflow-level turbo credentials blanked for the install step. Unlike the removed job, this also covers @1c-odata/cli. A runtime dep dropped from a manifest is deliberately out of scope: prepack rebuilds dist and tsdown bundles whatever dependencies no longer lists, so the shipped tarball keeps working (verified empirically).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
@1c-odata/mcp-server— the remote Streamable-HTTP MCP server — from the monorepo. The package is not ready for release: it was never published to npm and needs more bake time. The full implementation is preserved on a standing restore PR (opened right after this merges) to land when it matures.What goes
packages/mcp-server/— the whole tree (113 files): server, OAuth/better-auth layer, Postgres multi-tenancy, admin panel, Docker/Caddy deploy, drizzle migrations, tests.ci.yml) — gates 2c/2d (auth-schema + drizzle append-only) and 8b (Windows bin boot), and thedeploy-pg-smoke/deploy-package-smokejobs. None of them are required checks in the branch ruleset (verified againstrules/branches/master), so no ruleset change is needed.deploy-compose.yml,release-image.yml, and thepublish-imagejob (with itsoutputsplumbing) inrelease.yml. The npm publish path is untouched.docker/docker-composeentries for the deploy tree and the better-auth group exclusions (the dependency family leaves the workspace entirely)..dockerignore— only served the mcp-server image build context.mcp-server-*changesets;@1c-odata/mcp-serverdropped from thefixedgroup and fromnode-24-lts-floor.md. The@1c-odata/mcpchangelog entries that lived inside two deleted changesets (the/internalre-exports) are preserved in a newmcp-internal-reexports.md.**/deploy/ci/**Biome override.What stays
The
@1c-odata/mcp/internalseam (already released in 0.6.0, exercised by mcp's own tests) stays intact; its docs now say "a multi-tenant host" instead of naming the removed package. Docs (CLAUDE.md/README.md/STABILITY.md) updated to the four-package layout.Merge-ordering note
changeset-release/master) currently predates this removal and would publish@1c-odata/mcp-server@0.7.0to npm — do not merge #57 before this PR. Once this lands,changesets/actionregenerates that branch automatically and the package drops out. The open better-auth Dependabot PRs (#157–#159) become obsolete for the same reason and will be closed by Dependabot on its next run.Follow-up
deploy-package-smokewas the only coverage of the published-tarball path (files/bin/ runtime-dep mistakes that publint+attw cannot see). A slimmed-down smoke for the four surviving packages is worth restoring separately.Local review before this PR: Codex (xhigh) — no findings; Claude reviewer (high) — 5 findings, all addressed or verified-invalid; security review — no findings.