configure.ac: fix --disable-static enabling static builds#4
Open
symphorien wants to merge 1 commit intohackerschoice:mainfrom
Open
configure.ac: fix --disable-static enabling static builds#4symphorien wants to merge 1 commit intohackerschoice:mainfrom
symphorien wants to merge 1 commit intohackerschoice:mainfrom
Conversation
The third argument of AC_ARG_ENABLE is an action executed when the flag --enable-static or --disable static is specified with any value, not an action taken when the flag is set to true/yes. So --disable-static would enable static builds unconditionally.
Member
|
yepp. well spotted. thanks. Need valid GH signature to merge please. I'll merge it manually for now. thank you for packaging it for NixOS. |
Contributor
Author
|
thank you for merging. |
Member
|
uhh oh, did not work. see #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for reviving dsniff. I am a downstream distro maintainer (for NixOS) and the new maintainership is an occasion for me to propose autoconf improvements which would make building dsniff on NixOS easier.
The third argument of AC_ARG_ENABLE is an action executed when the flag --enable-static or --disable static is specified with any value, not an action taken when the flag is set to true/yes. So --disable-static would enable static builds unconditionally.