Refactor/design - #347
Merged
Merged
Refactor/design#347
Conversation
…ps and waiting for grouping feature
Structural changes: - Add database_cleaner-active_record to test group for truncation between browser tests (replaces transactional rollback for system tests) - Register :propro_headless_chrome driver with console logging prefs - Create BrowserSystemTestCase base class with proper setup/teardown (viewport resize, DatabaseCleaner start/clean, wait_for_turbo helper) - Add TestSupport::WithClues module for browser log/HTML dumps on failure - Blank fixture_table_names for system tests (100% FactoryBot, no fixtures) - Increase Capybara.default_max_wait_time to 5s for parallel contention CI fix: - Remove install-chromedriver from ci.yml (Selenium Manager resolves the matching driver for installed Chrome; bundling its own chromedriver broke system tests with version mismatch) Test conversions: - Convert all browser tests to inherit BrowserSystemTestCase - Remove per-test use_transactional_tests, driven_by, teardown, login_as overrides (now inherited from base) - Fix sidebar_collapse before/after idiom (scroll main, not window) - Fix tabs_sticky scroll_main to poll until scrolled (not one-shot) - Fix tabs_sticky sidebar pin assertion to use before/after geometry comparison instead of hardcoded pixel offsets - Fix mobile_overflow drawer test to dispatch Escape via window keyboard event (Selenium send_keys to unfocused headless window drops events) - Fix course_tab_persistence and sidebar_collapse to use scripted clicks for elements where headless Chrome intermittently swallows trusted clicks (reproduced as cold-worker first-click failures under full parallelism) - Revert settings_coursecode_test to page.execute_script approach (this specific turbo-method link is unreliable with both native and Capybara click methods; scripted click is the only deterministic path) - Delete dead tmp_fill_probe_test.rb - Delete stale storage/*.sqlite3* files (PostgreSQL is now the sole DB) All changes verified: bin/rails test (155 runs, 0 failures) and bin/rails test:system ×3 (78 runs each, 0 failures, different seeds)
KisuHypee
added a commit
that referenced
this pull request
Sep 12, 2026
Revert "Merge pull request #347 from hackerspacemmu/refactor/design"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.