This repository was archived by the owner on Jul 6, 2019. It is now read-only.
Generate layout.ld from templates + data#408
Open
mcoffin wants to merge 2 commits intohackndev:masterfrom
Open
Generate layout.ld from templates + data#408mcoffin wants to merge 2 commits intohackndev:masterfrom
mcoffin wants to merge 2 commits intohackndev:masterfrom
Conversation
1 similar comment
Contributor
Author
|
Looks like rebuilding everything for every example is starting to bit us in the butt a little. Might have to split each example in to it's own travis matrix now, which would... suck to say the least. Or at least provide a way to build example subsets until we could finally use cargo's |
farcaller
approved these changes
Dec 16, 2016
Contributor
Author
|
@farcaller I'm gonna hold off on this until we can fix the build times issue, especially since it doesn't truly add a ton of value quite yet until the generator can get more advanced. |
farcaller
reviewed
Jan 7, 2017
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| vectors: rom | |||
| memories: [] | |||
Member
There was a problem hiding this comment.
This naming is slightly awkward. Why not memory_ranges?
Contributor
Author
There was a problem hiding this comment.
Agreed. Much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #329
Obvously,
k20is still a special case, but I think this gives a good base on which to build a generator that will work generically accross all supported MCUs. (We still have #109) to track thek20layout in.I would make an attempt, but I don't have a k20 board or anything, so maybe @bgamari could take a look at some additions to this generator?
I think the way forward is to have like
flash_config: Option[McuFlashConfig]inMcuLayoutand thenstruct McuFlashConfig { ... }elsewhere... but that could be a naive solution that I just came up with at first glance.