Conversation
Author
|
@codex review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a repository publishes its first release, an existing commit-based installation can stop receiving update notifications if its abbreviated SHA parses as a version. For example,
3730b11is considered newer than0.2.0, sopending_updatereturnsFalse.Only compare release versions when
installed_versionis set. Commit-based installations fall through to the existing comparison instead. Tests cover both parseable and non-parseable SHAs, older/equal/newer release versions, and an explicitly selected default branch.Fixes #5504.
Validation: all 435 tests pass with Home Assistant 2025.3.0 and Python 3.13.12, matching the minimum-version CI job. The two parseable-SHA regression cases fail before the fix. Pre-commit checks pass for all changed files.