Pessimistic Velo LP Oracle - Review (#152)#153
Closed
piesrtasty wants to merge 4 commits into
Closed
Conversation
* fix: H-01Single-feed TWAP inversion underreports missing-token prices and persists poisoned lows * H-02Stale Velodrome TWAP ratios can overvalue one-feed LP collateral * fix: M-01 Yearn vault share prices are mis-scaled for non-18-decimal vault shares * fix: M-04 Stable LP pricing overvalues depegged Velodrome stable pools * fix: M-05 Pessimistic LP pricing omits sequencer grace checks and reuses pre-outage lows * fix: M-06 Stale pessimistic operator observations can overvalue LP collateral * M-11 Single-feed volatile LP oracle mixes stale TWAP prices with current reserves * fix: M12 Transient vault donations can be cached as collateral value * Fixed L-01 Fixed tiny TWAP quote overvalues low-precision missing-feed tokens * fix: L-03 Stable LP pricing can overflow at large valid reserve sizes * fix: L-04 Recorded zero daily lows can be overwritten or ignored * fix: L-05 Stable LP oracle price can round to zero for sub-millidollar assets * fix: L-06 Stable single-feed TWAP can revert on very large reserve observations * fix: L-07 TWAP-derived zero token price can be persisted as a daily low * fix: L-08 ERC4626 vault shares can be overvalued by fee-exclusive conversion * fix: L-09 Three-day pessimistic pricing can return before the three-day window is populated * fix: L-10 Overflow-sized pool reserves can brick Velo LP oracle updates * fix: L-11 Pessimistic oracle expiry can leave stale collateral prices active
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 161d35f719
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
* fix: H-04/L-17 fail-closed Velo vault share value and no-op update guard * fix: M-13/M-16 TWAP-averaged single-feed LP price cap for volatile and stable pools * fix: M-14 recheck dual-feed stable depeg on the pessimistic read path * fix: L-12/L-16/L-20/L-22 fail-soft single-feed daily-low clamp * fix: L-13/L-19 numeric edge cases in volatile geomean and TWAP derivation * fix: L-18 gate TWAP window on post-sequencer-recovery observations * fix: L-15 propagate delayed-oracle invalidation via OracleJob without reward farming * test: add integration/boundary regression tests for v2 fixes (H-04, L-15, L-18, L-20/L-22, L-12, L-16)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: H-01Single-feed TWAP inversion underreports missing-token prices and persists poisoned lows
H-02Stale Velodrome TWAP ratios can overvalue one-feed LP collateral
fix: M-01 Yearn vault share prices are mis-scaled for non-18-decimal vault shares
fix: M-04 Stable LP pricing overvalues depegged Velodrome stable pools
fix: M-05 Pessimistic LP pricing omits sequencer grace checks and reuses pre-outage lows
fix: M-06 Stale pessimistic operator observations can overvalue LP collateral
M-11 Single-feed volatile LP oracle mixes stale TWAP prices with current reserves
fix: M12 Transient vault donations can be cached as collateral value
Fixed L-01 Fixed tiny TWAP quote overvalues low-precision missing-feed tokens
fix: L-03 Stable LP pricing can overflow at large valid reserve sizes
fix: L-04 Recorded zero daily lows can be overwritten or ignored
fix: L-05 Stable LP oracle price can round to zero for sub-millidollar assets
fix: L-06 Stable single-feed TWAP can revert on very large reserve observations
fix: L-07 TWAP-derived zero token price can be persisted as a daily low
fix: L-08 ERC4626 vault shares can be overvalued by fee-exclusive conversion
fix: L-09 Three-day pessimistic pricing can return before the three-day window is populated
fix: L-10 Overflow-sized pool reserves can brick Velo LP oracle updates
fix: L-11 Pessimistic oracle expiry can leave stale collateral prices active