all: remove NSInvocation usage#3441
Merged
Merged
Conversation
# Conflicts: # internal/cocoa/api_cocoa_darwin.go # internal/graphicsdriver/metal/mtl/mtl_darwin.go
Owner
|
Awesome, but what's the difference from the last attempt? |
Owner
Is this it? |
Contributor
Author
Correct. The reason amd64 was crashing before was because it didn't pass all the parameters because there wasn't enough slots. Arm64 packs its arguments more efficiently which is why it worked there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
Updates #3135
What type of issue is this addressing?
feature
What this PR does | solves
This is a reissue of #3432 to remove NSInvocation after the inclusion of ebitengine/purego#431 which adds enough arguments to support calling CopyFromTexture on amd64 directly.
Ran both amd64 and arm64 to check it works:
Resolves ebitengine/purego#290