add tax_calculation_method :ITEM_BASED which changes tax amount validation to item based #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation to item based
Owner
|
Hmmmpfff, this feels like we need to overhaul this but maybe it is also just a function of the inherent complexity. I'll merge this for now, but I'm not happy with amassing all of these various modes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another of those specific use-cases I'm afraid:
We are rounding taxes on a per-line-item basis, not like Secretariat currently validates for on a per-taxrate basis.
The new :NONE option doesn't work here, because it actually changes the taxes. What we need is to just change / skip the"Base amount and summed tax base amount" validation.
By using the new :ITEM_BASED option, the validation now compares the invoice's tax_amount with the sum of the item tax amounts.