Improve Serial port detection.#314
Open
wb8tyw wants to merge 1 commit intoham-radio-software:masterfrom
Open
Conversation
Instead of trying to scan the serial ports with platform specific methods, use the python provided serial.tools.list_ports - changes/309.bugfix - changes/310.bugfix Tickets fixed by this PR. - d_rats/dplatform_generic.py Add platform independent list of serial ports - d_rats/dplatform_macos.py - d_rats/dplatform_unix.py - d_rats/dplatform_win32.py Remove no longer needed serial port listing method. Original Author: Github user Initram
wb8tyw
force-pushed
the
wb8tyw_serial_fix_via_initram
branch
from
bb993ed to
5d1d333
Compare
wb8tyw
requested review from
KP4AJ,
dscp46,
dslotter,
flyingfrawg,
ioClarity,
ka5mye,
marknoble,
maurizioandreotti,
riggs498 and
yo2loj
Contributor
Author
|
Attention MAC-OS users, please test this change to make sure that it works. Github tests results look good for Windows and Linux, but the MAC-OS runners do not appear to have any serial ports to detect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of trying to scan the serial ports with platform specific methods, use the python provided serial.tools.list_ports
changes/309.bugfix
changes/310.bugfix Tickets fixed by this PR.
d_rats/dplatform_generic.py Add platform independent list of serial ports
d_rats/dplatform_macos.py
d_rats/dplatform_unix.py
d_rats/dplatform_win32.py Remove no longer needed serial port listing method.
Original Author: Github user Initram