Cmake build has done#3
Open
muhammadhasnain12 wants to merge 24 commits into
Open
Conversation
ahmed-nad
reviewed
Sep 4, 2020
Comment on lines
+3
to
+6
|
|
||
|
|
||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
remove these extra lines
Collaborator
Author
There was a problem hiding this comment.
Removed Extra Lines
ahmed-nad
reviewed
Sep 4, 2020
|
|
||
|
|
||
|
|
||
| add_executable(roadtesting main.cpp Map.cpp Map.h Lane.cpp Lane.h Road.cpp Road.h) |
ahmed-nad
reviewed
Sep 4, 2020
Comment on lines
+9
to
+10
| # target_link_libraries(cmake-good PRIVATE Say_hello) | ||
| #target_link_libraries(ROADTESTING PRIVATE Map) No newline at end of file |
ahmed-nad
reviewed
Sep 4, 2020
|
|
||
| auto all_roads = v.get("roads").get<array>(); | ||
| // Loading the map file | ||
| // Loading the map file |
ahmed-nad
reviewed
Sep 4, 2020
| Road road{tid, tlb, trb, tl}; | ||
| // fill other road data | ||
| roads_.push_back(road); | ||
| roads_.push_back(road); |
ahmed-nad
reviewed
Sep 4, 2020
| float get_right_boundary_id(){return right_boundary_id;} | ||
| std::vector<Lane> get_lanes(){return lanes;} | ||
| std::vector<Lane> get_lanes(){return lanes;} | ||
|
|
ahmed-nad
reviewed
Sep 4, 2020
Comment on lines
+2
to
+5
| <CodeBlocks_project_file> | ||
| <FileVersion major="1" minor="6" /> | ||
| <Project> | ||
| <Option title="RoadTesting" /> |
ahmed-nad
reviewed
Sep 4, 2020
| @@ -1,7 +1,11 @@ | |||
| #include "Map.h" | |||
|
|
|||
| using namespace std; | |||
ahmed-nad
reviewed
Sep 4, 2020
| { | ||
| Map map; | ||
| map.load_data_from_file("map.json"); | ||
| // map.get_road2_id(); |
ahmed-nad
requested changes
Sep 4, 2020
ahmed-nad
left a comment
ahmed-nad
left a comment
Collaborator
There was a problem hiding this comment.
- Remove extra files
- Remove unecessary includes
- Don't ever upload build artifacts such as .o and .exe files and ide project related files
- add a .gitignore file to ignore these files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All files with cmake files