Skip to content

the npm deploy links to npm - #115

Merged
hamzafer merged 2 commits into
mainfrom
npm-deploy-link
Oct 15, 2026
Merged

hamzafer merged 2 commits into
mainfrom
npm-deploy-link

Conversation

@hamzafer

Copy link
Copy Markdown
Owner

The "npm" entry under Deployments on the repo page now links to the version's npm page (environment.url). GitHub's Packages box only lists GitHub Packages, so this is the repo page's link to npm.

  • publish-cli.yml: the job's environment gets a url built from the version the check step outputs. Same environment name, so npm's trusted publisher is unchanged.
  • test/workflows.test.mjs: accepts the environment: { name: npm } form (still fails with no environment).

Merging runs the workflow once (the file changed): 0.2.1 is already on npm, so it publishes nothing and records the link.

🤖 Generated with Claude Code

@hamzafer hamzafer self-assigned this Oct 15, 2026
@hamzafer

Copy link
Copy Markdown
Owner Author

Review outcomes

Sonnet review, one Codex pass (gpt-5.6-luna), one fix batch (bcf8c39) verified by a Sonnet agent and CI.

Finding Outcome
Sonnet: the first commit had no workflow change (a local restore after a mutation test reverted it) Fixed: the environment block with url is in the PR
Codex P2: the test accepted a sibling name: npm beside an empty environment: (job gets no environment) Fixed: name must be nested under environment (mutation-tested)
Sonnet: the test accepted npm-test Fixed: the name must be exactly npm (mutation-tested)
Skipped runs need a URL too Already so: version= is written before the check
Version flows into an output and a URL Hardened: the step fails on anything that isn't a plain semver
Flow style or url before name is rejected by the test No change: fails safe, the real file uses block form with name first

@hamzafer
hamzafer merged commit 3bae40c into main Oct 15, 2026
3 checks passed
@hamzafer
hamzafer deleted the npm-deploy-link branch October 15, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant