Update and rename download_data.py to Optimized_download_data.py#7
Open
thisisvk45 wants to merge 1 commit intohannahawalsh:mainfrom
Open
Update and rename download_data.py to Optimized_download_data.py#7thisisvk45 wants to merge 1 commit intohannahawalsh:mainfrom
thisisvk45 wants to merge 1 commit intohannahawalsh:mainfrom
Conversation
I optimized the `Data` class by consolidating file paths into a dictionary, streamlining data loading with a dictionary comprehension, and using `os.path.exists()` for direct directory checks. I also simplified the multiplication of numerical columns by iterating over ESG-related keys, making the code cleaner and more efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I optimized the
Dataclass by consolidating file paths into a dictionary, streamlining data loading with a dictionary comprehension, and usingos.path.exists()for direct directory checks. I also simplified the multiplication of numerical columns by iterating over ESG-related keys, making the code cleaner and more efficient.