Repository navigation
Conversation
…actions Hiding the wrapper label and re-drawing it inside the field content cut the field's hint, hint icon and hint actions loose — they rendered in a row of their own above the plugin's header. The switch is now an after-label component: Filament's own label row stays (accessible, inline-label aware), the hints keep their place and the switch sits at its end. Switch and panes live in different Alpine scopes, so they talk through a msu-tab event keyed by the field. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The file pane is the field's own wrapped content; wrapping it together with the URL pane put the label row inside the file pane, where showing the URL pane hid it — and the switch with it. wrapEmbeddedHtml() is the seam between content and wrapper, so the panes join there and the label row stays put whichever pane is showing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field with
->hint()/->hintIcon()/->hintAction()currently loses that row's layout:hiddenLabel()removes the wrapper label, the plugin re-draws the label inside the field content, and Filament renders the hints in a row of their own above it (screenshot: ahintAction(WebSearchAction …)ended up as an orphan line above «Label | File / From URL»).This PR keeps Filament's own label row and adds the source switch to it as an after-label component, after the hints:
MultiSourceFileUpload::setUp()wraps the existing after-label closure (the hints) and appends aViewcomponent with the switch when URL import is on; no morehiddenLabel().components/source-switch.blade.php) and the panes live in different Alpine scopes, so they talk through amsu-tabCustomEvent keyed by the field ($dispatchfrom the switch,$watch('tab')from the panes so a finished import flips the switch back to File).fi-fo-field-label-contentper field.🤖 Generated with Claude Code