Skip to content

Consolidate route rewrites to netlify.toml and enforce in CI#10

Open
harbourviewcompany-create wants to merge 1 commit into
mainfrom
codex/consolidate-rewrite-configuration-sources
Open

Consolidate route rewrites to netlify.toml and enforce in CI#10
harbourviewcompany-create wants to merge 1 commit into
mainfrom
codex/consolidate-rewrite-configuration-sources

Conversation

@harbourviewcompany-create
Copy link
Copy Markdown
Owner

Motivation

  • Keep Netlify route rewrites in a single authoritative location to avoid configuration drift and surprises at deploy time.
  • Remove duplicate entries that previously lived in both _redirects and netlify.toml to simplify maintenance.
  • Add automated validation so CI can detect regressions if someone reintroduces duplicates or removes required rewrites.

Description

  • Chose netlify.toml as the single source of truth for route rewrites and removed the duplicate rewrite lines from _redirects, leaving a comment pointing maintainers to netlify.toml.
  • Updated README.md deploy notes to state that route rewrites are maintained in netlify.toml ([[redirects]]).
  • Modified scripts/check-site.js to remove _redirects from the required files list, add a requiredRewrites array, add an escapeRegExp helper, verify each required rewrite exists in netlify.toml with status = 200, and fail if those same rewrite lines appear in _redirects.
  • Kept all required route mappings pointing to their .html pages so public routes still resolve to the expected pages.

Testing

  • Ran npm run check (which runs node scripts/check-site.js) and it passed with no failures.
  • The updated scripts/check-site.js was exercised by the same check and verified it detects presence/absence of the expected rewrites and duplicates as intended.

Codex Task

@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2026

Deploy Preview for wurx-can ready!

Name Link
🔨 Latest commit 6162249
🔍 Latest deploy log https://app.netlify.com/projects/wurx-can/deploys/6a0d2b3f86a4f300081f523d
😎 Deploy Preview https://deploy-preview-10--wurx-can.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Warning

Rate limit exceeded

@harbourviewcompany-create has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 3 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 78902d23-9687-44e1-8f7e-ffe389f43add

📥 Commits

Reviewing files that changed from the base of the PR and between 6e00de5 and 6162249.

📒 Files selected for processing (3)
  • README.md
  • _redirects
  • scripts/check-site.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2026

Deploy Preview for wurx-otta ready!

Name Link
🔨 Latest commit 6162249
🔍 Latest deploy log https://app.netlify.com/projects/wurx-otta/deploys/6a0d2b403dee900009a0fdfc
😎 Deploy Preview https://deploy-preview-10--wurx-otta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant