Add Windows desktop support - #46
Open
nonlooped wants to merge 6 commits into
Open
Conversation
- run agent CLIs and terminals with Windows-native process handling\n- normalize Windows paths and add Acrylic window styling\n- build, test, and publish an NSIS installer\n\nCloses hardbeat920#18
# Conflicts: # CHANGELOG.md # src-tauri/src/harness.rs # src-tauri/src/pty.rs
Owner
|
Thanks for adding this @nonlooped ! CI is passing on all platforms now. Before merging, could you check a few things the review flagged?
I haven’t verified these at runtime on Windows, so please let me know if any are already handled. Thank you again 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds Windows as a supported desktop target: Windows-native PTYs and process handling, drive/UNC-safe path normalization, Acrylic window styling, and an NSIS installer published by the release workflow. CI now checks macOS, Linux, and Windows.
Why
MonoCode's terminal, CLI discovery, filesystem paths, and release pipeline assumed Unix. This removes those assumptions so the existing feature set works on Windows and closes #18.
UI
Windows Acrylic and terminal:
NSIS installer:
Validation
npm run check:web— 1,017 tests passed; TypeScript passedcargo fmt --checkcargo +stable-x86_64-pc-windows-msvc clippy --workspace --all-targets -- -D warningscargo +stable-x86_64-pc-windows-msvc test— 145 tests passednpm run build:windows— producedMonoCode_0.1.28_x64-setup.exeChecklist
npm run checkCloses #18