Properly close tabs and files of archived or deleted sessions - #70
Conversation
|
@hardbeat920 this PR fixes the bug I mentioned. Let me know if there are any changes I need to make. |
|
Thanks for the fix @kinsomicrote the workspace behavior makes sense and the lifecycle helper is well tested. Before merging, could we address two persistence races?
Please stop/invalidate and flush first, persist the latest snapshot successfully when archiving, and serialize deletion after pending upserts. Integration tests covering archive/delete during an active turn would be valuable. Thanks again 🙏 |
… preserve resurrection
|
@hardbeat920 I've updated the PR. |
|
@kinsomicrote thank you! Merged :) |
What changed
Why
Before now, archiving a session left the tab in place, which is inconsistent with expectations. Deleting a session promoted open files to a session tab.
UI
Checklist
npm run check