-
Notifications
You must be signed in to change notification settings - Fork 0
Rebrand MeshChat as OrcMesh #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <# | ||
| .SYNOPSIS | ||
| Bootstrap the MeshChat development environment. | ||
| Bootstrap the OrcMesh development environment. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Update the remaining bootstrap status text. The banner now says OrcMesh, but Line 38 still prints Also applies to: 12-12 🧰 Tools🪛 PSScriptAnalyzer (1.25.0)[warning] Missing BOM encoding for non-ASCII encoded file 'bootstrap.ps1' (PSUseBOMForUnicodeEncodedFile) 🤖 Prompt for AI Agents |
||
| .DESCRIPTION | ||
| Creates a virtual environment, installs the package in editable mode with | ||
| all dev dependencies. Run once after cloning, or again to upgrade deps. | ||
|
|
@@ -9,7 +9,7 @@ $ErrorActionPreference = "Stop" | |
| $root = Split-Path $PSScriptRoot -Parent | ||
| Set-Location $root | ||
|
|
||
| Write-Host "==> MeshChat bootstrap" -ForegroundColor Cyan | ||
| Write-Host "==> OrcMesh bootstrap" -ForegroundColor Cyan | ||
|
|
||
| # ── Python version check ──────────────────────────────────────────────────── | ||
| $py = Get-Command python -ErrorAction SilentlyContinue | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: hardcoreerik/OrcMesh
Length of output: 17066
🏁 Script executed:
Repository: hardcoreerik/OrcMesh
Length of output: 3513
🌐 Web query:
Inno Setup upgrade behavior AppId unchanged existing files old shortcuts not removed💡 Result:
In Inno Setup, the AppId directive is the primary identifier used to maintain the relationship between installations [1][2]. When you keep the AppId the same across versions, Inno Setup treats the new installation as an upgrade to the existing one [1][2]. This behavior is intentional and generally correct for software updates [1][3]. Regarding your observations: 1. Existing Files: Inno Setup does not automatically remove files from a previous installation if they are not part of the new installer's file list [4][1]. It simply installs the new files over the old ones [3]. If you have files that were present in an older version but are no longer needed in the new version, they will remain in the installation directory [4][1]. To handle this, you should use the [InstallDelete] section to explicitly list any obsolete files that need to be removed during the upgrade process [4][1][5]. Avoid using wildcards in this section to prevent accidental deletion of user data or system files [6][3]. 2. Old Shortcuts: If shortcuts (icons) from an old version are not being updated or removed, verify that the [Icons] section entries in your new script match those of the old script. Inno Setup is designed to overwrite existing shortcuts if the name and location match. If you have renamed or removed an icon entry from the [Icons] section, it will not be automatically deleted from the user's system by the installer [6]. To remove old shortcuts that are no longer part of your application, you must include them in the [InstallDelete] section or, more commonly, handle their cleanup via custom Pascal scripting during the install process if necessary [6][5]. 3. Best Practices for Upgrades: - Always keep the AppId consistent across updates for the same application [1][2]. - Set DisableDirPage=auto and DisableProgramGroupPage=auto in the [Setup] section [1]. This ensures the installer defaults to the previous installation path and prevents confusion during upgrades [1]. - Do not attempt to uninstall the previous version before installing the new one; simply installing over the existing files is the standard, recommended approach for Inno Setup [1][3]. - If you find that files are persisting after uninstallation, ensure that the files were actually installed by the Inno Setup installer. Inno Setup's uninstaller only removes files that it tracked during the installation process [6]. If you have files created by the application at runtime (like logs or user data), these will not be removed by default [6]. If you ever intend for a new version to be installed side-by-side with an older one rather than upgrading it, you must change the AppId to a new, unique value for the new installer [7][8].
Citations:
Remove legacy MeshChat files and shortcuts during upgrades.
AppIdis unchanged, so this installs over an existing MeshChat installation. Inno Setup does not remove obsolete files or shortcuts that are not part of the current installer script. AddInstallDeleteentries for obsolete files such asMeshChat.exe, and clean up old shortcuts if the previous installation created them. Test an in-place upgrade from a previous MeshChat installation.🤖 Prompt for AI Agents