CLI-54049: add GatewayAPI spec related objects#198
Open
luisbarrueco wants to merge 3 commits intomainfrom
Open
CLI-54049: add GatewayAPI spec related objects#198luisbarrueco wants to merge 3 commits intomainfrom
luisbarrueco wants to merge 3 commits intomainfrom
Conversation
gyoza
approved these changes
Mar 2, 2026
luisbarrueco
commented
Mar 3, 2026
| {{- if .ingress -}} | ||
| {{- $ingress = .ingress }} | ||
| {{- end }} | ||
| {{- if and $.Values.global.gatewayAPI.enabled $.Values.global.ingress.enabled -}} |
Author
There was a problem hiding this comment.
A note to self, so I don't forget later. Maybe it would be best to have
Suggested change
| {{- if and $.Values.global.gatewayAPI.enabled $.Values.global.ingress.enabled -}} | |
| {{- if $.Values.global.gatewayAPI.enabled -}} |
so that we don't run into issues when we try to remove the nginx software eventually?
We are still going to rely on ingress.objects, so we'll need to keep those keys. But the global.ingress part might go away when we eventually uninstall nginx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a template definition for stock HTTPRoute and Envoy's HTTPRouteFilter objects that are "compatible" with the definitions we currently have for services
ingress:.This means that we can set
and have an application render the
HTTPRoute*resources along with theIngressobjects that will allow us to switch the routing from an Ingress controller into an Envoy Gateway GatewayAPI implementation.The code is a little bit convoluted and totally "coupled" with the way we configure Ingresses today, so it's not a generic/flexible implementation of HTTPRoutes. It has been done like this so that we can migrate traffic away from the ingress-nginx controller without application reconfiguration (other than that global setting.)