Steady state replication throttling POC - #3
Open
harrylin98 wants to merge 35 commits into
Open
harrylin98 wants to merge 35 commits into
harrylin98 wants to merge 35 commits into
Conversation
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
…ths (valkey-io#3600) The `pending_command` flag indicates that a client has a fully parsed command ready for execution. This update ensures that the flag is set/cleared consistently across different execution paths. --------- Signed-off-by: harrylin98 <harrylin980107@gmail.com>
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
4 times, most recently
from
June 24, 2026 04:54
430a560 to
72ebc75
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
from
June 24, 2026 05:29
72ebc75 to
5904359
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
JimB123
suggested changes
Jun 24, 2026
JimB123
left a comment
JimB123
left a comment
There was a problem hiding this comment.
I focused on the APIs. Big comments:
- APIs (.h files) need solid documentation
- Avoid pulling in Amazon overdesign
- Consider each thing in the .h file. Ask does this need to be part of the API? Why?
| long oldest_client_delay_us; | ||
| } throttleMetrics; | ||
|
|
||
| /* Public API */ |
There was a problem hiding this comment.
The public API should be fully documented.
There was a problem hiding this comment.
+1, This is applicable to all the .h files we have included here.
|
|
||
| void tokenBucket_capDebt(tokenBucket *bucket, double max_debt); | ||
| double tokenBucket_add(tokenBucket *bucket, double tokens); | ||
| double tokenBucket_replenish(tokenBucket *bucket); |
There was a problem hiding this comment.
No need for this to be an API. This can happen intrinsically.
dubey02
reviewed
Jul 6, 2026
| long oldest_client_delay_us; | ||
| } throttleMetrics; | ||
|
|
||
| /* Public API */ |
There was a problem hiding this comment.
+1, This is applicable to all the .h files we have included here.
| tokenBucket *bucket; | ||
| list *client_queue; | ||
| listNode *ln; /* my node in throttlerList */ | ||
| monotime rate_below_guardrail_since; |
There was a problem hiding this comment.
Isn't this field more related to repl-throttle specifically? I think a generic throttle framework shouldn't care about guardrails. Can we please track it in throttle-repl.c somewhere ?
| static list *throttlerList = NULL; | ||
| static hashtable *metricsTable = NULL; | ||
|
|
||
| typedef struct throttler { |
There was a problem hiding this comment.
One liner Documentation on structures and its members would help the readability.
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
from
July 10, 2026 19:11
041c81d to
ec331ac
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
8 times, most recently
from
July 14, 2026 08:44
802f610 to
9a1ca67
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
2 times, most recently
from
July 21, 2026 00:16
e99ce3d to
53b098f
Compare
harrylin98
force-pushed
the
rate_limit_poc
branch
2 times, most recently
from
July 21, 2026 23:30
81ade19 to
c2a2485
Compare
harrylin98
force-pushed
the
rate_limit_poc
branch
from
August 12, 2026 00:59
35244c2 to
8f30657
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
from
August 13, 2026 21:54
7aaa28a to
2d69b73
Compare
harrylin98
force-pushed
the
rate_limit_poc
branch
from
August 17, 2026 03:51
84d90a9 to
b819547
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
from
August 17, 2026 03:57
b819547 to
31e9714
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
3 times, most recently
from
August 18, 2026 22:29
7253432 to
b050201
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
from
August 24, 2026 08:24
fe4577b to
9749a33
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
4 times, most recently
from
August 26, 2026 15:45
aa49e5d to
c0d21c6
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
rate_limit_poc
branch
from
August 31, 2026 16:13
4851661 to
6cd9f79
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.