Summarize unclaimed rows in table_splitter.ambiguous suggestion#90
Merged
Conversation
Instead of enumerating every unclaimed row index into one sentence (which produced multi-hundred-thousand-character lines on large or irregular tables), report the count plus a small capped sample. Closes #88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
binoc.table_splitter.ambiguoussuggestion joined every unclaimed row index into a single sentence, so on large or irregular tables one suggestion ballooned to a multi-hundred-thousand-character line.This change replaces the full enumeration with a count plus a small capped sample (up to 5 indices, then
… and N more), e.g.:Small lists (≤5) are still enumerated in full. Added a unit test asserting the summary stays short regardless of row count.
Closes #88
(Auto generated pull request)