Skip to content

Revert change to org user removal flow.#3737

Merged
rebeccacremona merged 1 commit into
harvard-lil:developfrom
rebeccacremona:revert-remove-user-behavior
Sep 18, 2025
Merged

Revert change to org user removal flow.#3737
rebeccacremona merged 1 commit into
harvard-lil:developfrom
rebeccacremona:revert-remove-user-behavior

Conversation

@rebeccacremona
Copy link
Copy Markdown
Contributor

This PR restores the previous behavior of the flow to remove users from an organization: after form submission, the submitter is returned to the list of org users.

The tweak to redirect instead to a user-specific page was introduced in 8558fa3#diff-86c1f99e1e554ec8cf5e888d2c1033ffdced7ca1d91459906e8b37cdd67b711f. It works for admins, but 403s for registrar users. I'll make sure that, going forward, the tests pick that up, as part of the general refactoring of tests in #3621

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.57%. Comparing base (8fc6741) to head (6432a4b).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3737      +/-   ##
===========================================
+ Coverage    69.47%   69.57%   +0.09%     
===========================================
  Files           58       58              
  Lines         7837     7843       +6     
===========================================
+ Hits          5445     5457      +12     
+ Misses        2392     2386       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rebeccacremona rebeccacremona merged commit 270c5eb into harvard-lil:develop Sep 18, 2025
2 checks passed
@rebeccacremona rebeccacremona deleted the revert-remove-user-behavior branch September 25, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants